Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							ef060ed40c 
							
						 
					 
					
						
						
							
							result: Add default error code for the ResultCode(-1) case  
						
						... 
						
						
						
						Will be used to reduce the overall duplication of the same magic value
all over the codebase in following changes. 
						
						
					 
					
						2019-11-12 07:55:38 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							581d2e36e5 
							
						 
					 
					
						
						
							
							crypto: Resolve sign-conversion warnings  
						
						
						
						
					 
					
						2019-11-12 07:55:22 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							27ab99490e 
							
						 
					 
					
						
						
							
							result: Resolve sign-coversion warnings  
						
						... 
						
						
						
						The constructor was implicitly using signed->unsigned conversions to
produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX. 
						
						
					 
					
						2019-11-12 07:06:48 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							19a0abc19b 
							
						 
					 
					
						
						
							
							arm_unicorn: Resolve sign conversion warnings  
						
						... 
						
						
						
						While we're at it, this also resolves a type truncation warning as well,
given the code was truncating from a 64-bit value to a 32-bit one. 
						
						
					 
					
						2019-11-12 07:06:48 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							96d677bef0 
							
						 
					 
					
						
						
							
							CMakeLists: Make most implicit type conversion warnings errors on MSVC  
						
						... 
						
						
						
						Quite frequently there have been cases where code has been merged into
the core that produces warning. In order to prevent this from occurring,
we can make the compiler flag these cases and allow our CI to flag down
any code that would generate these warnings.
This is beneficial given silent conversions from signed/unsigned can
result in logic bugs. This forces one writing changes to be explicit
about when signedness conversions are desirable, rather than leaving it
up to readers' interpretation.
Currently the codebase isn't in a state where it will build successfully
with this change applied, but this will be addressed in subsequent
follow-up changes. This set of changes will focus on making it build
properly with these changes for MSVC as a starting point for basic
coverage. 
						
						
					 
					
						2019-11-12 07:06:25 -05:00 
						 
				 
			
				
					
						
							
							
								Michael Scire 
							
						 
					 
					
						
						
						
						
							
						
						
							b0b0786493 
							
						 
					 
					
						
						
							
							Implement stub for QueryApplicationPlayStatisticsByUid  
						
						
						
						
					 
					
						2019-11-11 07:32:47 -08:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							3c95e49c42 
							
						 
					 
					
						
						
							
							nifm: Only return that there's an internet connection when there's a BCATServer  
						
						... 
						
						
						
						This helps games that need internet for other purposes boot as the rest
of our internet infrastructure is incomplete. 
						
						
					 
					
						2019-11-06 23:10:32 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							c1a3d19897 
							
						 
					 
					
						
						
							
							Merge pull request  #3062  from bunnei/event-improve  
						
						... 
						
						
						
						kernel: Improve events 
						
						
					 
					
						2019-11-06 10:05:50 -05:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0e34f648f4 
							
						 
					 
					
						
						
							
							Merge pull request  #2859  from Morph1984/hid  
						
						... 
						
						
						
						hid: Stub SetNpadJoyAssignmentModeSingle and GetNpadHandheldActivationMode 
						
						
					 
					
						2019-11-06 12:48:07 +11:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
						
						
							
						
						
							1bdae0fe29 
							
						 
					 
					
						
						
							
							common_func: Use std::array for INSERT_PADDING_* macros.  
						
						... 
						
						
						
						- Zero initialization here is useful for determinism. 
						
						
					 
					
						2019-11-03 22:22:41 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
						
						
							
						
						
							ece5287843 
							
						 
					 
					
						
						
							
							kernel: readable_event: Signal only once.  
						
						
						
						
					 
					
						2019-11-03 04:25:41 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
						
						
							
						
						
							b0ab803ce8 
							
						 
					 
					
						
						
							
							kernel: events: Remove ResetType::Automatic.  
						
						... 
						
						
						
						- This does not actually seem to exist in the real kernel - games reset these automatically.
# Conflicts:
#	src/core/hle/service/am/applets/applets.cpp
#	src/core/hle/service/filesystem/fsp_srv.cpp 
						
						
					 
					
						2019-11-03 04:22:45 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
						
						
							
						
						
							28bb248db6 
							
						 
					 
					
						
						
							
							kernel: readable_event: Initialize members.  
						
						
						
						
					 
					
						2019-11-03 04:18:39 -05:00 
						 
				 
			
				
					
						
							
							
								FearlessTobi 
							
						 
					 
					
						
						
						
						
							
						
						
							832c138eff 
							
						 
					 
					
						
						
							
							core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility  
						
						... 
						
						
						
						These commands require Screenshots to be implemented anyway, so they are safe to stub for now. 
						
						
					 
					
						2019-11-03 07:37:38 +01:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							04b838c857 
							
						 
					 
					
						
						
							
							Merge pull request  #3038  from lioncash/docs  
						
						... 
						
						
						
						kernel/scheduler: Minor changes 
						
						
					 
					
						2019-10-30 03:47:28 +00:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a81bd962ab 
							
						 
					 
					
						
						
							
							Merge pull request  #3007  from DarkLordZach/fsc-regress  
						
						... 
						
						
						
						savedata_factory: Automatically create certain savedata 
						
						
					 
					
						2019-10-29 22:05:09 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							6c8f28813c 
							
						 
					 
					
						
						
							
							scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as const  
						
						... 
						
						
						
						This is only compared against, so it can be made const. 
						
						
					 
					
						2019-10-27 23:35:50 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							f19c1a7cda 
							
						 
					 
					
						
						
							
							scheduler: Silence sign conversion warnings  
						
						
						
						
					 
					
						2019-10-27 22:44:52 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							2fb0bbff29 
							
						 
					 
					
						
						
							
							scheduler: Initialize class members directly where applicable  
						
						... 
						
						
						
						Reduces the overall amount of code. 
						
						
					 
					
						2019-10-27 22:13:55 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							2dc469ceba 
							
						 
					 
					
						
						
							
							scheduler: Amend documentation comments  
						
						... 
						
						
						
						Adjusts the formatting of a few of the comments an ensures they get
recognized as proper Doxygen comments. 
						
						
					 
					
						2019-10-27 22:12:32 -04:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4c5731c34f 
							
						 
					 
					
						
						
							
							Merge pull request  #2971  from FernandoS27/new-scheduler-v2  
						
						... 
						
						
						
						Kernel: Implement a New Thread Scheduler V2 
						
						
					 
					
						2019-10-28 10:53:27 +11:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6fe89acf0d 
							
						 
					 
					
						
						
							
							Merge pull request  #2991  from lioncash/npad  
						
						... 
						
						
						
						hid/npad: Minor cleanup 
						
						
					 
					
						2019-10-22 19:51:24 -04:00 
						 
				 
			
				
					
						
							
							
								Zach Hilman 
							
						 
					 
					
						
						
						
						
							
						
						
							bb207fe27a 
							
						 
					 
					
						
						
							
							savedata_factory: Automatically create certain savedata  
						
						... 
						
						
						
						After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use.
In these 3 specific instances, the save is created automatically for the game if it doesn't exist. 
						
						
					 
					
						2019-10-22 15:47:38 -04:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
						
						
							
						
						
							a86a88109a 
							
						 
					 
					
						
						
							
							core: Fix clang-format errors.  
						
						
						
						
					 
					
						2019-10-19 14:47:18 -04:00 
						 
				 
			
				
					
						
							
							
								Nicolae-Andrei Cociorba 
							
						 
					 
					
						
						
						
						
							
						
						
							20521da259 
							
						 
					 
					
						
						
							
							Fix null pointer deref.  
						
						
						
						
					 
					
						2019-10-18 14:12:12 +00:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d1713ad451 
							
						 
					 
					
						
						
							
							Merge pull request  #2992  from lioncash/dmnt  
						
						... 
						
						
						
						dmnt_cheat_vm: Correct register Restore and ClearRegs behavior 
						
						
					 
					
						2019-10-17 19:52:24 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							2c34d8aabb 
							
						 
					 
					
						
						
							
							dmnt_cheat_vm: Correct register Restore and ClearRegs behavior  
						
						... 
						
						
						
						Previously these were performing the same behavior as the Save and
ClearSaved opcode types. 
						
						
					 
					
						2019-10-17 18:49:39 -04:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7cf091bb20 
							
						 
					 
					
						
						
							
							Merge pull request  #2989  from lioncash/apm  
						
						... 
						
						
						
						service/apm/controller: Minor interface changes 
						
						
					 
					
						2019-10-17 19:20:14 -03:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							8d8e495248 
							
						 
					 
					
						
						
							
							hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers()  
						
						... 
						
						
						
						We should be setting the connection state to true, otherwise we aren't
actually making the controllers connected like the function name
indicates. 
						
						
					 
					
						2019-10-17 18:19:47 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							d076466f26 
							
						 
					 
					
						
						
							
							hid/npad: Add missing break in default case  
						
						... 
						
						
						
						While not an issue, it does prevent fallthrough from occurring if
anything is ever added after this case (unlikely to occur, but this
turns a trivial "should not cause issues" into a definite "won't cause
issues). 
						
						
					 
					
						2019-10-17 18:17:42 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							26c84718c8 
							
						 
					 
					
						
						
							
							hid/npad: Replace std::for_each with ranged for loops  
						
						... 
						
						
						
						Performs the same behavior, but is built into the core language itself.
No functional change. 
						
						
					 
					
						2019-10-17 18:16:36 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							e433e99191 
							
						 
					 
					
						
						
							
							hid/npad: Remove redundant non-const variant of IsControllerSupported()  
						
						... 
						
						
						
						The const qualified variant can also be called in non-const contexts, so
we can remove the non-const variant to eliminate a bit of code
duplication. 
						
						
					 
					
						2019-10-17 18:11:41 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							a71e8066a1 
							
						 
					 
					
						
						
							
							hid/npad: Move function declarations  
						
						... 
						
						
						
						Clearly separate these from the variable declarations to make them more
visible. 
						
						
					 
					
						2019-10-17 18:09:08 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							98c6a95079 
							
						 
					 
					
						
						
							
							core/core: Resolve -Wreorder warnings  
						
						... 
						
						
						
						Amends the initializer lists to be ordered in the same manner that
they're declared within the class. 
						
						
					 
					
						2019-10-17 17:51:06 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							6414d9e2e5 
							
						 
					 
					
						
						
							
							core/memory/cheat_engine: Resolve -Wreorder warnings  
						
						... 
						
						
						
						Amends the initializer lists to be ordered in the same manner that
they're declared within the class. 
						
						
					 
					
						2019-10-17 16:21:47 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							b77430df70 
							
						 
					 
					
						
						
							
							apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a map  
						
						... 
						
						
						
						While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.
Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.
This eliminates a static constructor and places the data into the
read-only segment.
While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator. 
						
						
					 
					
						2019-10-17 16:13:14 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							141d929929 
							
						 
					 
					
						
						
							
							apm/controller: Make GetCurrentPerformanceMode() a const member function  
						
						... 
						
						
						
						This doesn't modify instance state, so it can be made const qualified. 
						
						
					 
					
						2019-10-17 15:58:25 -04:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ef9b31783d 
							
						 
					 
					
						
						
							
							Merge pull request  #2912  from FernandoS27/async-fixes  
						
						... 
						
						
						
						General fixes to Async GPU 
						
						
					 
					
						2019-10-16 10:34:48 -04:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2299950de1 
							
						 
					 
					
						
						
							
							Merge pull request  #2972  from lioncash/system  
						
						... 
						
						
						
						{bcat, gpu, nvflinger}: Remove trivial usages of the global system accessor 
						
						
					 
					
						2019-10-15 17:49:12 -04:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							cc1d7048b5 
							
						 
					 
					
						
						
							
							bcat: Remove use of global system accessors  
						
						... 
						
						
						
						Removes all uses of the global system accessor within the BCAT
interface. 
						
						
					 
					
						2019-10-15 16:39:27 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							64e652d8cb 
							
						 
					 
					
						
						
							
							Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE.  
						
						
						
						
					 
					
						2019-10-15 11:55:30 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							e28c7f5217 
							
						 
					 
					
						
						
							
							Kernel: Address Feedback 2  
						
						
						
						
					 
					
						2019-10-15 11:55:28 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							a3524879be 
							
						 
					 
					
						
						
							
							Kernel: Clang Format  
						
						
						
						
					 
					
						2019-10-15 11:55:27 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							c32520ceb7 
							
						 
					 
					
						
						
							
							Kernel: Reverse global accessor removal.  
						
						
						
						
					 
					
						2019-10-15 11:55:26 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							3073615dbc 
							
						 
					 
					
						
						
							
							Kernel: Address Feedback.  
						
						
						
						
					 
					
						2019-10-15 11:55:25 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							25f8606a6d 
							
						 
					 
					
						
						
							
							Kernel Scheduler: Make sure the global scheduler shutdowns correctly.  
						
						
						
						
					 
					
						2019-10-15 11:55:24 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							b3c1deba49 
							
						 
					 
					
						
						
							
							Kernel_Thread: Eliminate most global accessors.  
						
						
						
						
					 
					
						2019-10-15 11:55:23 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							0b72b34d89 
							
						 
					 
					
						
						
							
							KernelSVC: Assert that condition variable address is aligned to 4 bytes.  
						
						
						
						
					 
					
						2019-10-15 11:55:22 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							96b1b144af 
							
						 
					 
					
						
						
							
							Kernel: Correct Paused scheduling  
						
						
						
						
					 
					
						2019-10-15 11:55:21 -04:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
						
						
							
						
						
							1c6a11ab14 
							
						 
					 
					
						
						
							
							Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel.  
						
						
						
						
					 
					
						2019-10-15 11:55:20 -04:00